-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic tests to the project #101
Add automatic tests to the project #101
Conversation
Signed-off-by: Fabio Kruger <krufab@gmail.com>
The problem is that you aren't a trusted contributor, so the CI will not use your Jenkinsfile changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with introducing some smoke tests in the repository. OTOH it might be preferable to consider doing real integration tests. It might require using a more advanced test framework, e.g. for putting Jenkins into testcontainers
@oleg-nenashev, there is an integration test in jnlp-slave. @slide , i'll revert the build.sh so that the tests can be executed |
@krufab I was not saying that you should revert build.sh, I am just telling you why the CI is failing. What I can do is submit a shadow PR with your same changes so that the CI will actually run using the Jenkinsfile changes, would that be ok with you? |
@slide, I guess it's ok, yes |
Signed-off-by: Fabio Kruger <krufab@gmail.com>
Signed-off-by: Fabio Kruger <krufab@gmail.com>
@slide, Bats doesn't seem to be installed on the test server. I reverted the build.sh file, removed make tests and now it builds. You can run the tests on your local machine and check if they are ok. When the build server will be able to run the tests, I'll re-enable them. |
If you look at the master docker repo, you can see that bats is a submodule. That would be the way to go here too. |
I pulled in all the latest changes into my duplicate PR so we can see the Jenkinsfile changes in action |
#102 is passing for all the checks including the tests |
Is it ok this PR or is there anything to change? |
I am happy with this, if @oleg-nenashev has no objections, I think it can be merged. I will look at adding some simple pester based tests for the Windows side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Added tests to the project, as per issue #100